this prefix required#12081
Closed
thomasleplus wants to merge 1 commit intoapache:masterfrom
thomasleplus:patch-1
Closed
this prefix required#12081thomasleplus wants to merge 1 commit intoapache:masterfrom thomasleplus:patch-1
thomasleplus wants to merge 1 commit intoapache:masterfrom
thomasleplus:patch-1
Conversation
This line was actually assigning the method argument to itself instead of setting the static field of the same name.
Contributor
Author
|
Wrong fix, will submit another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This line was actually assigning the method argument to itself instead of setting the static field of the same name.
Motivation
Fix a simple mistake.
Modifications
Trivial change.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?