[Java Client] Remove unnecessary stats incremement#12229
Merged
merlimat merged 1 commit intoapache:masterfrom Sep 30, 2021
Merged
[Java Client] Remove unnecessary stats incremement#12229merlimat merged 1 commit intoapache:masterfrom
merlimat merged 1 commit intoapache:masterfrom
Conversation
Member
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
@merlimat @BewareMyPower - PTAL, thanks! |
merlimat
approved these changes
Sep 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Java client currently increments a stat with the size of pending messages queue. This would make sense, except for the fact that the queue is cleared right before getting the size. Further, the stat in question is incremented within the
failPendingMessagesmethod, which is called right before the removed line.Modifications
stats.incrementSendFailed();, since it is unnecessary.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
This change does not affect any public behavior.
Documentation
No docs need updating.