[Issue #12485][Python Client] and [Issue #12486][Python Client]#12487
Closed
tsturzl wants to merge 3 commits intoapache:masterfrom
Closed
[Issue #12485][Python Client] and [Issue #12486][Python Client]#12487tsturzl wants to merge 3 commits intoapache:masterfrom
tsturzl wants to merge 3 commits intoapache:masterfrom
Conversation
if keys exist before deleting
Contributor
|
@tsturzl:Thanks for your contribution. For this PR, do we need to update docs? |
Contributor
|
@tsturzl:Thanks for your contribution. For this PR, do we need to update docs? |
Contributor
|
@tsturzl:Thanks for providing doc info! |
merlimat
reviewed
Oct 25, 2021
| def get_state(self, key): | ||
| """get the value of a given key in the managed state""" | ||
| pass | ||
| """Interface defining information available at process time""" |
Contributor
There was a problem hiding this comment.
The re-indent and changes to " vs ' should be in a different PR.
We should have one commit that just fixed the single problem described.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #12485
Fixes #12486
Motivation
I found several issues in the python client. First there were some
Nonechecks which were too inclusive and didn't allow the use of0values for numeric types as well as some other odd behaviors. Secondly JsonSchema did not allow a Record to be used more than once since it deleted fields which wouldn't exist on the second use.Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-docThese changes don't change how you use the client, they just fix the behavior to be more inline with what would be expected
doc(If this PR contains doc changes)