Skip to content

Allow WebSocketHttpServletRequestWrapperTest run on windows#12589

Merged
merlimat merged 1 commit intoapache:masterfrom
hezhangjian:WebSocketHttpServletRequestWrapperTest
Nov 2, 2021
Merged

Allow WebSocketHttpServletRequestWrapperTest run on windows#12589
merlimat merged 1 commit intoapache:masterfrom
hezhangjian:WebSocketHttpServletRequestWrapperTest

Conversation

@hezhangjian
Copy link
Member

@hezhangjian hezhangjian commented Nov 2, 2021

Motivation

Allow unit tests run on windows

Modifications

Change the file path to compat windows and unix

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc

    Simple unit tests change

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

@shoothzj:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-label-missing doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Nov 2, 2021
@github-actions
Copy link

github-actions bot commented Nov 2, 2021

@shoothzj:Thanks for providing doc info!

@merlimat merlimat added this to the 2.10.0 milestone Nov 2, 2021
@merlimat merlimat merged commit f0413b1 into apache:master Nov 2, 2021
@hezhangjian hezhangjian deleted the WebSocketHttpServletRequestWrapperTest branch November 3, 2021 00:59
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants