[SpotBugs][pulsar-io]Enable spotbugs for pulsar-io-hdfs2 and pulsar-io-hdfs3#12782
[SpotBugs][pulsar-io]Enable spotbugs for pulsar-io-hdfs2 and pulsar-io-hdfs3#12782codelipenghui merged 1 commit intoapache:masterfrom
Conversation
|
@fxbing:Thanks for your contribution. For this PR, do we need to update docs? |
| <artifactId>spotbugs-maven-plugin</artifactId> | ||
| <version>${spotbugs-maven-plugin.version}</version> | ||
| <configuration> | ||
| <excludeFilterFile>${basedir}/src/main/resources/findbugsExclude.xml</excludeFilterFile> |
There was a problem hiding this comment.
It seems we don't need to set excludeFilterFile since it's empty.
There was a problem hiding this comment.
@Jason918 Looking forward to your confirmation and reply.
|
@fxbing seems that this PR does not need to update docs? P.S. when submitting a PR, can you provide a doc label (tick the box) in the PR template contains info about doc? This helps others know more about the changes. Thanks |
|
@fxbing:Thanks for providing doc info! |
github-actions
bot
added
doc-not-needed
|
@Anonymitaet done |
|
|
||
| --> | ||
| <FindBugsFilter> | ||
| </FindBugsFilter> No newline at end of file |
There was a problem hiding this comment.
| </FindBugsFilter> | |
| </FindBugsFilter> | |
There was a problem hiding this comment.
better to add new line on file end
6 participants
Master Issue: #8843
Motivation
Enable spotbugs for the pulsar-io module.
Modifications
Enable soptbugs for pulsar-io-hdfs2 and pulsar-io-hdfs3
Verifying this change
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)