Skip to content

Comments

[Java Client] Use info, not warn, log level when successfully registe…#12819

Merged
merlimat merged 1 commit intoapache:masterfrom
michaeljmarshall:update-client-log-level-for-successful-event
Nov 15, 2021
Merged

[Java Client] Use info, not warn, log level when successfully registe…#12819
merlimat merged 1 commit intoapache:masterfrom
michaeljmarshall:update-client-log-level-for-successful-event

Conversation

@michaeljmarshall
Copy link
Member

…ring schema

Motivation

Use INFO log level when a successful event happens. The Pulsar Coding Guide mentions that WARN is only for "bad" events. https://pulsar.apache.org/en/coding-guide/#logging-levels

WARN and ERROR indicate something that is BAD. Use WARN if you aren't totally sure it is bad, and ERROR if you are.

Modifications

  • Switch warn to log in the java client

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

  • no-need-doc

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 15, 2021
@michaeljmarshall
Copy link
Member Author

/pulsarbot run-failure-checks

@merlimat merlimat added this to the 2.10.0 milestone Nov 15, 2021
@merlimat merlimat added the type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages label Nov 15, 2021
@merlimat merlimat merged commit e993f32 into apache:master Nov 15, 2021
eolivelli pushed a commit that referenced this pull request Nov 16, 2021
eolivelli pushed a commit to eolivelli/pulsar that referenced this pull request Nov 29, 2021
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants