[PIP 97][SASL Authentication] Remove Deprecated SASL AuthenticationDataSource#authenticate Implementation

[michaeljmarshall]

Master Issue: PIP 97 #12105

Motivation

When the SASL Authentication Provider was created in #3821, it introduced an authenticate method into the AuthenticationDataSource. This method is not necessary, and was marked as deprecated in PIP 97: #12105. This PR breaks the SASL Authentication Provider's reliance on the AuthenticationDataSource#authenticate method.

As an added benefit, the AuthenticationDataSource is only a data source now. It is no longer overloaded as a data source and a means of authenticating data.

I plan to submit a subsequent PR to remove the SaslAuthenticationDataSource. This change is valuable by itself because it removes the reliance on AuthenticationDataSource#authenticate.

Note also that SaslAuthenticationState#authenticate is also deprecated in PIP 97. I want to first get this merged before moving to the async variant.

Modifications

• Update SaslAuthenticationDataSource to remove unnecessary method declarations.
• Update constructor for SaslAuthenticationState to only take the PulsarSaslServer as a parameter.
• Update implementation of several methods in SaslAuthenticationState so that they no longer rely on the SaslAuthenticationDataSource.

Verifying this change

This change is internal to the SASL provider itself. It is covered by existing tests.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

• Dependencies (does it add or upgrade a dependency): no
• The public API: no
• The schema: no
• The default values of configurations: no
• The wire protocol: no
• The rest endpoints: no
• The admin cli options: no
• Anything that affects deployment: no

Documentation

• no-need-doc

This is a completely internal update, so no docs need updating.

[michaeljmarshall]

@jiazhai, @merlimat, @eolivelli - PTAL

[michaeljmarshall]

/pulsarbot run-failure-checks

[eolivelli]

+1