Add guide to copy file source connector to container#12978
Merged
Anonymitaet merged 5 commits intoapache:masterfrom Dec 6, 2021
Haaroon:docs-file-io-connector-copy
Merged
Add guide to copy file source connector to container#12978Anonymitaet merged 5 commits intoapache:masterfrom Haaroon:docs-file-io-connector-copy
Anonymitaet merged 5 commits intoapache:masterfrom
Haaroon:docs-file-io-connector-copy
Conversation
Added instruction to copy file source connector into docker image. Adjusted numbers accordingly
Anonymitaet
reviewed
Nov 26, 2021
tuteng
reviewed
Nov 26, 2021
Contributor
Author
|
Perfect, i have added the suggestions, thank you. its ready to be merged at your discretion |
Anonymitaet
reviewed
Dec 2, 2021
Anonymitaet
approved these changes
Dec 2, 2021
Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
Contributor
Author
|
all requested changes have been commited. |
tuteng
approved these changes
Dec 6, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
* Add guide to copy file source connector to container Added instruction to copy file source connector into docker image. Adjusted numbers accordingly * spelling correction * added restart command and sentence suggestion * Update site2/docs/io-file-source.md Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com> Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added instruction to copy file source connector into docker image.
Adjusted numbers accordingly
Motivation
Modifications
I have adjusted the guide to tell the user to copy the connector to the docker instance
Verifying this change
This change is already covered by existing tests
Does this pull request potentially affect one of the following parts:
Documentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc