Skip to content

Add guide to copy file source connector to container#12978

Merged
Anonymitaet merged 5 commits intoapache:masterfrom
Haaroon:docs-file-io-connector-copy
Dec 6, 2021
Merged

Add guide to copy file source connector to container#12978
Anonymitaet merged 5 commits intoapache:masterfrom
Haaroon:docs-file-io-connector-copy

Conversation

@Haaroon
Copy link
Contributor

@Haaroon Haaroon commented Nov 25, 2021

Added instruction to copy file source connector into docker image.
Adjusted numbers accordingly

Motivation

  • I am testing out the file source connector and it would not run without this command

Modifications

I have adjusted the guide to tell the user to copy the connector to the docker instance

Verifying this change

This change is already covered by existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no
  • The rest endpoints: no
  • The admin cli options: no
  • Anything that affects deployment: no

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc

Added instruction to copy file source connector into docker image. 
Adjusted numbers accordingly
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Nov 25, 2021
@Haaroon
Copy link
Contributor Author

Haaroon commented Dec 2, 2021

Perfect, i have added the suggestions, thank you. its ready to be merged at your discretion

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@Haaroon
Copy link
Contributor Author

Haaroon commented Dec 2, 2021

all requested changes have been commited.

@Haaroon Haaroon requested a review from tuteng December 5, 2021 20:13
@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Dec 6, 2021
@Anonymitaet Anonymitaet merged commit e01ff0f into apache:master Dec 6, 2021
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
* Add guide to copy file source connector to container

Added instruction to copy file source connector into docker image. 
Adjusted numbers accordingly

* spelling correction

* added restart command and sentence suggestion

* Update site2/docs/io-file-source.md

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants