Skip to content

[Metadata] Attempt to fix flakiness in ZKSessionTest and quarantine the test#13087

Merged
eolivelli merged 1 commit intoapache:masterfrom
lhotari:lh-fix-ZkSessionTest-flakiness
Dec 2, 2021
Merged

[Metadata] Attempt to fix flakiness in ZKSessionTest and quarantine the test#13087
eolivelli merged 1 commit intoapache:masterfrom
lhotari:lh-fix-ZkSessionTest-flakiness

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Dec 2, 2021 •
edited
Loading

Motivation

ZKSessionTest is very flaky. See #13008.

Modifications

  • quarantine the test until the flakiness is fully fixed.
  • improvements in this PR as an attempt to fix flakiness:
    • improve clean up of TestZKServer which left uncleaned resources running.
      • The session tracker thread was duplicated after stop/start
    • Reduce tick time used in TestZKServer
    • Reduce session expiration timeout in tests
    • Increase timeout for polling in tests

@lhotari lhotari added this to the 2.10.0 milestone Dec 2, 2021
@lhotari lhotari self-assigned this Dec 2, 2021
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

@lhotari:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@lhotari lhotari added the doc-not-needed Your PR changes do not impact docs label Dec 2, 2021
@lhotari lhotari requested review from eolivelli and merlimat December 2, 2021 10:23
@github-actions
Copy link

github-actions bot commented Dec 2, 2021

@lhotari:Thanks for providing doc info!

@lhotari lhotari force-pushed the lh-fix-ZkSessionTest-flakiness branch from 3521acf to 2adcb05 Compare December 2, 2021 10:43
@lhotari lhotari changed the title [Metadata] Fix flakiness in ZKSessionTest [Metadata] Attempt to fix flakiness in ZKSessionTest and quarantine the test Dec 2, 2021
Jason918
Jason918 approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

eolivelli
eolivelli approved these changes Dec 2, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@eolivelli eolivelli merged commit 9eaf2b5 into apache:master Dec 2, 2021
@yuruguo yuruguo mentioned this pull request Dec 3, 2021
Merged
1 task
fxbing pushed a commit to fxbing/pulsar that referenced this pull request Dec 19, 2021
@lhotari
Attempt to fix flakiness in ZKSessionTest and quarantine the test (ap…
a6ca36d 
…ache#13087)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Jason918 Jason918 Jason918 approved these changes

@eolivelli eolivelli eolivelli approved these changes

@merlimat merlimat Awaiting requested review from merlimat

Assignees

@lhotari lhotari

Labels

doc-not-needed Your PR changes do not impact docs type/flaky-tests

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lhotari @Jason918 @eolivelli