Skip to content

cleanup code for ZkBookieRackAffinityMapping#13113

Closed
StevenLuMT wants to merge 1 commit intoapache:masterfrom
StevenLuMT:apache_master_lusj_dev
Closed

cleanup code for ZkBookieRackAffinityMapping#13113
StevenLuMT wants to merge 1 commit intoapache:masterfrom
StevenLuMT:apache_master_lusj_dev

Conversation

@StevenLuMT
Copy link
Member

Descriptions of the changes in this PR:

Motivation

Simple code cleanup

Modifications

  1. no use import UnknownHostException for ZkBookieRackAffinityMapping

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

@StevenLuMT:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@nicoloboschi
Copy link
Contributor

I see checkstyle shows 63 errors for pulsar-zookkeeper-utils, including unused imports. (the one @StevenLuMT is fixing in this PR)
Is there any reason why we don't strictly follow checkstyle and attach it at the compile phase in every sub-projects? @eolivelli @lhotari @codelipenghui @merlimat

@hezhangjian
Copy link
Member

hezhangjian commented Dec 3, 2021

The master doesn't have this problem at now.

@hezhangjian
Copy link
Member

I see checkstyle shows 63 errors for pulsar-zookkeeper-utils, including unused imports. (the one @StevenLuMT is fixing in this PR) Is there any reason why we don't strictly follow checkstyle and attach it at the compile phase in every sub-projects? @eolivelli @lhotari @codelipenghui @merlimat
In my memory, this config of checkstyle only checks file that modified not every file in the project

@codelipenghui
Copy link
Contributor

@nicoloboschi I think we have some component have not apply the check style yet.

@codelipenghui
Copy link
Contributor

@StevenLuMT could you please help resolve the conflicts?

@merlimat
Copy link
Contributor

merlimat commented Dec 3, 2021

This class was already deleted/refactored in master branch

@Anonymitaet
Copy link
Member

@StevenLuMT for the doc side, this PR cleanup codes, so no need to update docs, correct?

@codelipenghui
Copy link
Contributor

This class was already deleted/refactored in master branch

Sorry @StevenLuMT I will close the PR for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants