You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@StevenLuMT:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
I see checkstyle shows 63 errors for pulsar-zookkeeper-utils, including unused imports. (the one @StevenLuMT is fixing in this PR)
Is there any reason why we don't strictly follow checkstyle and attach it at the compile phase in every sub-projects? @eolivelli@lhotari@codelipenghui@merlimat
I see checkstyle shows 63 errors for pulsar-zookkeeper-utils, including unused imports. (the one @StevenLuMT is fixing in this PR) Is there any reason why we don't strictly follow checkstyle and attach it at the compile phase in every sub-projects? @eolivelli@lhotari@codelipenghui@merlimat
In my memory, this config of checkstyle only checks file that modified not every file in the project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Simple code cleanup
Modifications