Fix typo in functions-work.yaml, add functionWebServiceUrl in yaml

[hezhangjian]

Modifications

Fix typo in functions-work.yaml, add functionWebServiceUrl in yaml

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

• no-need-doc

trival changes, no need doc

[hezhangjian]

@codelipenghui @lhotari @michaeljmarshall @merlimat @315157973 PTAL, thanks

[michaeljmarshall]

@shoothzj - can you provide a little more context for this change? Explicitly adding a default to the functions_worker.yml will change the default behavior. Thanks.

[michaeljmarshall]

I think this will change the behavior of the following code if workerHostname is overridden in this file and the operator is relying on the following conditional to set the functionWebServiceUrl. Why do we need to add this to the configuration?

pulsar/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/PulsarWorkerService.java

Lines 432 to 435 in 64bbbd4

	final String functionWebServiceUrl = StringUtils.isNotBlank(workerConfig.getFunctionWebServiceUrl())
	? workerConfig.getFunctionWebServiceUrl()
	: (workerConfig.getTlsEnabled()
	? workerConfig.getWorkerWebAddressTls() : workerConfig.getWorkerWebAddress());

pulsar/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java

Lines 618 to 620 in 64bbbd4

	public String getWorkerWebAddress() {
	return String.format("http://%s:%d", this.getWorkerHostname(), this.getWorkerPort());
	}

pulsar/pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java

Lines 599 to 604 in 64bbbd4

	public String getWorkerHostname() {
	if (isBlank(this.workerHostname)) {
	this.workerHostname = unsafeLocalhostResolve();
	}
	return this.workerHostname;
	}

[hezhangjian]

@shoothzj - can you provide a little more context for this change? Explicitly adding a default to the functions_worker.yml will change the default behavior. Thanks.

@michaeljmarshall
the field functionWebServiceUrl is widely used when people deploy function-works and pulsar-broker divided.
It is more reasonable for this frequently used configuration parameter to appear in the configuration file.
cc @merlimat @315157973

[hezhangjian]

ping @michaeljmarshall

[lhotari]

adding functionWebServiceUrl is a breaking change, please make that separately from other changes and bring it up to discussion on the mailing list for decision making.

[hezhangjian]

@lhotari Ok, I will start a thread on mail list, for now I will close this PR :)