Allow to config no-password truststore

[hezhangjian]

Motivation

Supprot to config truststore which password is empty ""

Modifications

• when password is null, load as ""

Verifying this change

• add test method to verify tls success

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

• no-need-doc

That's a little enhance, doesn't need doc

[michaeljmarshall]

I don't believe we're allowed to add binary files to our repo. @dave2wave and @eolivelli - can you confirm this for me?

[dave2wave]

I don't believe we're allowed to add binary files to our repo.

Assuming it is not possible to create this test file from source then to me this test case is reasonable.

It would be good to have a description of how these two keystores are created. Then we can determine if it is relatively simple to build.

[merlimat]

I don't believe we're allowed to add binary files to our repo. @dave2wave and @eolivelli - can you confirm this for me?

We do have binaries when it make sense. eg: PNG image for diagrams. I believe that if you want to test with a keystore and be able to read it, there's no other way than to include it.

Or if you want, just encode in base64.. which kind of demonstrate that bytes are bytes..

[hezhangjian]

@codelipenghui @lhotari @merlimat @315157973 @hangc0276 PTAL, thanks
@michaeljmarshall PTAL agian, thanks

[hezhangjian]

/pulsarbot run-failure-checks

[hezhangjian]

ping @michaeljmarshall

[michaeljmarshall]

Thanks for confirming @dave2wave and @merlimat.

LGTM

[BewareMyPower]

Hi, just a tip for new committers. When you merge a PR, it's better to copy and paste the PR description like

Otherwise, the commit log would only contain all the single commits like 53ad936

See a correct commit like: 40ac793

[hezhangjian]

Hi, just a tip for new committers. When you merge a PR, it's better to copy and paste the PR description like

Otherwise, the commit log would only contain all the single commits like 53ad936

See a correct commit like: 40ac793

Thank you, I haven't known that before, sorry for my fault.

[BewareMyPower]

Never mind. There was a PR that adds the guideline for merging a PR: #12988. It will be included in Pulsar 2.10.0 website.