Skip to content

fix(docs): broker metrics url#13433

Merged
Anonymitaet merged 1 commit intoapache:masterfrom
ericsyh:broker-metrics
Dec 23, 2021
Merged

fix(docs): broker metrics url#13433
Anonymitaet merged 1 commit intoapache:masterfrom
ericsyh:broker-metrics

Conversation

@ericsyh
Copy link
Contributor

@ericsyh ericsyh commented Dec 21, 2021

Signed-off-by: Eric Shen ericshenyuhao@outlook.com

Motivation

Broker uses Jetty as its http server, the route url for metrics is http://<broker-ip>:8000/metrics/ not the http://<broker-ip>:8000/metrics.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Dec 21, 2021

```shell
http://$BROKER_ADDRESS:8080/metrics
http://$BROKER_ADDRESS:8080/metrics/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @freeznet does the slash matter?

Copy link
Contributor

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Anonymitaet Anonymitaet merged commit c2a3293 into apache:master Dec 23, 2021
@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Dec 23, 2021
@ericsyh ericsyh deleted the broker-metrics branch December 24, 2021 11:29
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Dec 29, 2021
Signed-off-by: Eric Shen <ericshenyuhao@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants