Skip to content

Fix License check failure#13437

Merged
merlimat merged 1 commit intoapache:masterfrom
yuruguo:reduce_code_duplication_in_TopicsImpl
Dec 22, 2021
Merged

Fix License check failure#13437
merlimat merged 1 commit intoapache:masterfrom
yuruguo:reduce_code_duplication_in_TopicsImpl

Conversation

@yuruguo
Copy link
Contributor

@yuruguo yuruguo commented Dec 21, 2021

Motivation

From this PR

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

(If you need help on updating docs, create a doc issue)

  • no-need-doc

(Please explain why)

  • doc

(If this PR contains doc changes)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 21, 2021
@Technoboy-
Copy link
Contributor

Seems #13436 has done it.

@yuruguo yuruguo changed the title [pulsar-admin] Reduce code duplication in TopicsImpl reduce_code_duplication_in_TopicsImpl Dec 22, 2021
@yuruguo yuruguo changed the title reduce_code_duplication_in_TopicsImpl Fix License check failure Dec 22, 2021
@yuruguo
Copy link
Contributor Author

yuruguo commented Dec 22, 2021

Seems #13436 has done it.

Thanks for your reply, I see.
But I found other problem(from this PR) with License check failure, so I modified the PR to solve it.

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Dec 22, 2021
@merlimat merlimat merged commit b98f6f1 into apache:master Dec 22, 2021
Technoboy- pushed a commit to Technoboy-/pulsar that referenced this pull request Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants