Skip to content

[Doc] add custom properties for the reconsumeLater#13468

Merged
Anonymitaet merged 6 commits intoapache:masterfrom
liudezhi2098:add_doc_custom_properties_for_the_reconsumeLater
Dec 30, 2021
Merged

[Doc] add custom properties for the reconsumeLater#13468
Anonymitaet merged 6 commits intoapache:masterfrom
liudezhi2098:add_doc_custom_properties_for_the_reconsumeLater

Conversation

@liudezhi2098
Copy link
Contributor

@liudezhi2098 liudezhi2098 commented Dec 23, 2021 •
edited
Loading

This PR adds docs for Add custom properties for the reconsumeLater interface #13461
Preview looks good:
image

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc

@github-actions
Copy link

github-actions bot commented Dec 23, 2021

@liudezhi2098:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

Anonymitaet
Anonymitaet reviewed Dec 24, 2021
View reviewed changes
Copy link
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liudezhi2098 thanks for adding docs.
You are pretty professional since you preview doc changes locally before submitting a PR and show changes to us directly and clearly. This is a quite good example for all doc contributors. 👍

liudezhi2098 and others added 4 commits December 24, 2021 09:57
@liudezhi2098 @Anonymitaet
Update site2/docs/concepts-messaging.md
cb2f7ea 
agree

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@liudezhi2098 @Anonymitaet
Update site2/docs/concepts-messaging.md
77ec121 
agree

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@liudezhi2098 @Anonymitaet
Update site2/docs/concepts-messaging.md
3f65279 
agree

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@liudezhi2098 @Anonymitaet
Update site2/docs/concepts-messaging.md
7d27590 
agree

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
@Anonymitaet Anonymitaet added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Dec 24, 2021
@Anonymitaet
Copy link
Member

Anonymitaet commented Dec 24, 2021

@freeznet can you help review this PR from the technical perspective? Thanks

freeznet
freeznet reviewed Dec 24, 2021
View reviewed changes
Copy link
Contributor

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, but please check my comments as well, thanks.

site2/docs/concepts-messaging.md Outdated
Copy link
Contributor

@freeznet freeznet Dec 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you want to add custom properties for the reconsumeLater, you can use the following API.
If you want to add custom properties for the `reconsumeLater`, you can use the following API.

site2/docs/concepts-messaging.md
If you want to add custom properties for the reconsumeLater, you can use the following API.

```java
consumer.reconsumeLater(msg, customProperties, 3, TimeUnit.SECONDS);
Copy link
Contributor

@freeznet freeznet Dec 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show a more complete example including how to construct customProperties as well?

Copy link
Contributor Author

@liudezhi2098 liudezhi2098 Dec 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can provide a complete example

@liudezhi2098
Copy link
Contributor Author

liudezhi2098 commented Dec 28, 2021

@freeznet PTAL

freeznet
freeznet approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Dec 30, 2021
@Anonymitaet Anonymitaet merged commit 33c9dea into apache:master Dec 30, 2021
wuzhanpeng pushed a commit to wuzhanpeng/pulsar that referenced this pull request Jan 5, 2022
@liudezhi2098 @Anonymitaet
[Doc] add custom properties for the reconsumeLater (apache#13468)
be5516c 
* [Doc] add  custom properties for the reconsumeLater

* Update site2/docs/concepts-messaging.md

agree

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>

* Update site2/docs/concepts-messaging.md

agree

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>

* Update site2/docs/concepts-messaging.md

agree

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>

* Update site2/docs/concepts-messaging.md

agree

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>

* provide a complete example

Co-authored-by: Anonymitaet <50226895+Anonymitaet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freeznet freeznet freeznet approved these changes

@Anonymitaet Anonymitaet Anonymitaet approved these changes

Assignees

@liudezhi2098 liudezhi2098

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Milestone

2.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@liudezhi2098 @Anonymitaet @freeznet

Comments