Skip to content

fix: release note link anchor jumper incorrect in version page#13546

Merged
tuteng merged 2 commits intoapache:masterfrom
urfreespace:fix/version-release-note-jumper
Dec 29, 2021
Merged

fix: release note link anchor jumper incorrect in version page#13546
tuteng merged 2 commits intoapache:masterfrom
urfreespace:fix/version-release-note-jumper

Conversation

@urfreespace
Copy link
Member

Signed-off-by: LiLi urfree@apache.org

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #13545

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@urfreespace urfreespace requested a review from tuteng December 29, 2021 04:08
@urfreespace urfreespace self-assigned this Dec 29, 2021
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Dec 29, 2021
const React = require('react');

const CompLibrary = require('../../core/CompLibrary');
const CompLibrary = require("../../core/CompLibrary");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed that the file hasn't changed at all, right? It probably doesn't need to be formatted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thanks.

Signed-off-by: LiLi <urfree@apache.org>
@urfreespace urfreespace requested a review from tuteng December 29, 2021 06:37
@tuteng tuteng added this to the 2.10.0 milestone Dec 29, 2021
@tuteng tuteng merged commit d1b4255 into apache:master Dec 29, 2021
wuzhanpeng pushed a commit to wuzhanpeng/pulsar that referenced this pull request Jan 5, 2022
…e#13546)

* fix: release note link anchor jumper incorrect in version page

Signed-off-by: LiLi <urfree@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[website] Pulsar Version Page: Release note links cannot work well.

2 participants