Skip to content

[WIP]Support IP as advertisedAddress if not set#13590

Closed
AnonHxy wants to merge 1 commit intoapache:masterfrom
AnonHxy:conf/ipAsAdvertisedAddress
Closed

[WIP]Support IP as advertisedAddress if not set#13590
AnonHxy wants to merge 1 commit intoapache:masterfrom
AnonHxy:conf/ipAsAdvertisedAddress

Conversation

@AnonHxy
Copy link
Contributor

@AnonHxy AnonHxy commented Dec 31, 2021

Motivation

Sometimes we need use IP as advertisedAddress when executing automatic deployment

Modifications

  • Add the field ipAsAdvertisedAddress in ProxyConfiguration and ServiceConfiguration
  • Most changes are concentrated on org.apache.pulsar.broker.ServiceConfigurationUtils#getDefaultOrConfiguredAddress and org.apache.pulsar.broker.ServiceConfigurationUtils#unsafeLocalhostResolve

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Extended case MultipleListenerValidatorTest#testGetAppliedAdvertised

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • doc

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Dec 31, 2021
@AnonHxy AnonHxy force-pushed the conf/ipAsAdvertisedAddress branch 2 times, most recently from 98a3589 to 5767721 Compare December 31, 2021 10:30
@AnonHxy AnonHxy changed the title [WIP] Support IP as advertisedAddress if not set Support IP as advertisedAddress if not set Dec 31, 2021
@AnonHxy AnonHxy force-pushed the conf/ipAsAdvertisedAddress branch from 5767721 to 47ace51 Compare December 31, 2021 13:50
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Jan 2, 2022

/pulsarbot run-failure-checks

1 similar comment
@AnonHxy
Copy link
Contributor Author

AnonHxy commented Jan 3, 2022

/pulsarbot run-failure-checks

@AnonHxy AnonHxy changed the title Support IP as advertisedAddress if not set [WIP]Support IP as advertisedAddress if not set Jan 5, 2022
@AnonHxy AnonHxy force-pushed the conf/ipAsAdvertisedAddress branch from 47ace51 to 4f832fd Compare January 5, 2022 05:42
@AnonHxy AnonHxy force-pushed the conf/ipAsAdvertisedAddress branch from 4f832fd to 5378ec5 Compare January 5, 2022 05:56
@AnonHxy AnonHxy closed this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants