[WIP]Support IP as advertisedAddress if not set#13590
Closed
AnonHxy wants to merge 1 commit intoapache:masterfrom
Closed
[WIP]Support IP as advertisedAddress if not set#13590AnonHxy wants to merge 1 commit intoapache:masterfrom
AnonHxy wants to merge 1 commit intoapache:masterfrom
Conversation
98a3589 to
5767721
Compare
5767721 to
47ace51
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
Anonymitaet
reviewed
Jan 5, 2022
47ace51 to
4f832fd
Compare
4f832fd to
5378ec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes we need use IP as advertisedAddress when executing automatic deployment
Modifications
ipAsAdvertisedAddressinProxyConfigurationandServiceConfigurationorg.apache.pulsar.broker.ServiceConfigurationUtils#getDefaultOrConfiguredAddressandorg.apache.pulsar.broker.ServiceConfigurationUtils#unsafeLocalhostResolveVerifying this change
This change added tests and can be verified as follows:
MultipleListenerValidatorTest#testGetAppliedAdvertisedDoes this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
doc