Skip to content

fix checkstyle for tired-storage, websocket and bc modules#13748

Merged
eolivelli merged 6 commits intoapache:masterfrom
streamnative:neng/pulsar-module-checkstyle
Jan 20, 2022
Merged

fix checkstyle for tired-storage, websocket and bc modules#13748
eolivelli merged 6 commits intoapache:masterfrom
streamnative:neng/pulsar-module-checkstyle

Conversation

@nlu90
Copy link
Member

@nlu90 nlu90 commented Jan 13, 2022

Modifications

fixed module tiered-storage, pulsar-websocket and bouncycastle

Verifying this change

➜  sn-pulsar: mvn checkstyle:check -Dpulsar.basedir=.
[INFO] Apache Pulsar :: Tiered Storage :: Parent .......... SUCCESS [  0.048 s]
[INFO] Apache Pulsar :: Tiered Storage :: JCloud .......... SUCCESS [  0.395 s]
[INFO] Apache Pulsar :: Tiered Storage :: File System ..... SUCCESS [  0.058 s]
...
[INFO] Apache Pulsar :: Bouncy Castle :: Parent ........... SUCCESS [  0.033 s]
[INFO] Apache Pulsar :: Bouncy Castle :: BC ............... SUCCESS [  0.037 s]
[INFO] pulsar-client-messagecrypto-bc ..................... SUCCESS [  0.050 s]
...
➜  sn-pulsar git:(neng/pulsar-module-checkstyle) ✗ mvn checkstyle:check -Dpulsar.basedir=. -pl pulsar-websocket
[INFO] Scanning for projects...
[INFO] ------------------------------------------------------------------------
[INFO] Detecting the operating system and CPU architecture
[INFO] ------------------------------------------------------------------------
[INFO] os.detected.name: osx
[INFO] os.detected.arch: x86_64
[INFO] os.detected.classifier: osx-x86_64
[INFO]
[INFO] -----------------< org.apache.pulsar:pulsar-websocket >-----------------
[INFO] Building Pulsar WebSocket 2.10.0-SNAPSHOT
[INFO] --------------------------------[ jar ]---------------------------------
[INFO]
[INFO] --- maven-checkstyle-plugin:3.1.2:check (default-cli) @ pulsar-websocket ---
[INFO] You have 0 Checkstyle violations.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  2.048 s
[INFO] Finished at: 2022-01-13T18:04:04-08:00
[INFO] ------------------------------------------------------------------------

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    checkstyle fix

  • doc

    (If this PR contains doc changes)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 13, 2022
@nlu90 nlu90 marked this pull request as ready for review January 14, 2022 02:08
@nlu90
Copy link
Member Author

nlu90 commented Jan 14, 2022

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 18, 2022
@codelipenghui
Copy link
Contributor

@nlu90 Please help resolve the conflicts

@nlu90
Copy link
Member Author

nlu90 commented Jan 20, 2022

@codelipenghui Please take a look

@nlu90
Copy link
Member Author

nlu90 commented Jan 20, 2022

/pulsarbot run-failure-checks

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eolivelli eolivelli merged commit 898045a into apache:master Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments