Skip to content

[Tests] Workaround flakiness issue in EndToEndMetadataTest.testPublishConsume#13754

Merged
lhotari merged 1 commit intoapache:masterfrom
lhotari:lh-workaround-test-BKCluster-flakiness
Jan 14, 2022
Merged

[Tests] Workaround flakiness issue in EndToEndMetadataTest.testPublishConsume#13754
lhotari merged 1 commit intoapache:masterfrom
lhotari:lh-workaround-test-BKCluster-flakiness

Conversation

@lhotari
Copy link
Member

@lhotari lhotari commented Jan 14, 2022

Fixes #13750

Motivation

  • If the org.apache.bookkeeper.meta.MetadataDrivers class got loaded before org.apache.pulsar.metadata.bookkeeper.BKCluster constructor is called, things would fail.

Modifications

  • Set the system properties for metadata-store backend in pom.xml for all pulsar-broker tests as a workaround

…hConsume

- If the org.apache.bookkeeper.meta.MetadataDrivers class got loaded before org.apache.pulsar.metadata.bookkeeper.BKCluster constructor is called, things would fail.
- Set the system properties for metadata-store backend in pom.xml for all pulsar-broker tests as a workaround
@lhotari lhotari added type/flaky-tests doc-not-needed Your PR changes do not impact docs labels Jan 14, 2022
@lhotari lhotari self-assigned this Jan 14, 2022
@mattisonchao
Copy link
Member

@lhotari

Do we need to remove the following code ?

 public BKCluster(String metadataServiceUri, int numBookies) throws Exception { 
     // ----
     System.setProperty("bookkeeper.metadata.bookie.drivers", PulsarMetadataBookieDriver.class.getName()); 
     System.setProperty("bookkeeper.metadata.client.drivers", PulsarMetadataClientDriver.class.getName()); 
    //  ----
 } 

@lhotari
Copy link
Member Author

lhotari commented Jan 14, 2022

@lhotari

Do we need to remove the following code ?

 public BKCluster(String metadataServiceUri, int numBookies) throws Exception { 
     // ----
     System.setProperty("bookkeeper.metadata.bookie.drivers", PulsarMetadataBookieDriver.class.getName()); 
     System.setProperty("bookkeeper.metadata.client.drivers", PulsarMetadataClientDriver.class.getName()); 
    //  ----
 } 

No. That makes it work when running in IDEs that don't necessarily pick up maven pom.xml system properties. I'd rather wait for @merlimat 's opinion on a more intrusive fix.

@mattisonchao
Copy link
Member

I see, Thanks to your explanation. 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs type/flaky-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky-test: [EndToEndMetadataTest].[testPublishConsume]

3 participants

Comments