Skip to content

Comments

[DOCS] Update Messaging doc#13838

Merged
Anonymitaet merged 2 commits intoapache:masterfrom
sijia-w:msgging
Jan 21, 2022
Merged

[DOCS] Update Messaging doc#13838
Anonymitaet merged 2 commits intoapache:masterfrom
sijia-w:msgging

Conversation

@sijia-w
Copy link
Contributor

@sijia-w sijia-w commented Jan 19, 2022

Modifications

  • Add intro to message redelivery
  • Update the demo code of nack and ack timeout
  • Modify the content

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@sijia-w
Copy link
Contributor Author

sijia-w commented Jan 19, 2022

Thanks @gaoran10 for his input and @D-2-Ed for her review comments. Please help review the changes and look forward to your feedback.

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Jan 19, 2022
@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Jan 21, 2022
@Anonymitaet Anonymitaet merged commit 0fd12e6 into apache:master Jan 21, 2022
@sijia-w sijia-w deleted the msgging branch January 25, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants