Skip to content

[broker][code cleanup] remove unused static variable #14010

Merged
hezhangjian merged 1 commit intoapache:masterfrom
HQebupt:cleanCode2022
Jan 29, 2022
Merged

[broker][code cleanup] remove unused static variable #14010
hezhangjian merged 1 commit intoapache:masterfrom
HQebupt:cleanCode2022

Conversation

@HQebupt
Copy link
Contributor

@HQebupt HQebupt commented Jan 28, 2022

Motivation

Code cleanup, one static variable in PulsarWebResource is not used.

  • NOT_IMPLEMENTED

Modifications

Delete one static variable.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc
    Code cleanup.

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jan 28, 2022
@HQebupt
Copy link
Contributor Author

HQebupt commented Jan 28, 2022

/pulsarbot run-failure-checks

@codelipenghui codelipenghui added this to the 2.10.0 milestone Jan 28, 2022
@HQebupt
Copy link
Contributor Author

HQebupt commented Jan 29, 2022

/pulsarbot run-failure-checks

@hezhangjian hezhangjian merged commit 8dc8197 into apache:master Jan 29, 2022
@HQebupt HQebupt deleted the cleanCode2022 branch January 29, 2022 04:50
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
### Motivation
Code cleanup, one static variable in PulsarWebResource is not used.

- NOT_IMPLEMENTED

### Modifications
Delete one static variable.

### Verifying this change

- [x]  Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

### Does this pull request potentially affect one of the following parts:
If `yes` was chosen, please highlight the changes

- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (no)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)

### Documentation
Check the box below and label this PR (if you have committer privilege).

Need to update docs?
- [x] `no-need-doc` 
Code cleanup.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants