[Management] Make BrokerBase#getOwnedNamespaces to pure async.#14055
Closed
mattisonchao wants to merge 5 commits intoapache:masterfrom
mattisonchao:sync_to_async_getOwnedNamespaces
Closed
[Management] Make BrokerBase#getOwnedNamespaces to pure async.#14055mattisonchao wants to merge 5 commits intoapache:masterfrom mattisonchao:sync_to_async_getOwnedNamespaces
BrokerBase#getOwnedNamespaces to pure async.#14055mattisonchao wants to merge 5 commits intoapache:masterfrom
mattisonchao:sync_to_async_getOwnedNamespaces
Conversation
Member
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot rerun-failure-checks |
Technoboy-
reviewed
Feb 8, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java
Outdated
Show resolved
Hide resolved
Technoboy-
reviewed
Feb 8, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@Technoboy- PTAL :) |
Jason918
reviewed
Feb 9, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/BrokersBase.java
Show resolved
Hide resolved
Member
Author
|
/pulsarbot rerun-failure-checks |
mattisonchao
changed the title
BrokerBase#getOwnedNamespaces to pure async.BrokerBase#getOwnedNamespaces to pure async.
Technoboy-
approved these changes
Feb 9, 2022
jiazhai
approved these changes
Feb 9, 2022
Jason918
approved these changes
Feb 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Make
BrokerBase#getOwnedNamespacesto pure async.Modifications
BrokerBase#getOwnedNamespacesto pure async.Verifying this change
Documentation
no-need-doc