[Flaky-test] org.apache.pulsar.metadata.ZKSessionTest#testSessionLost #14189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaozhangmin
changed the title
merlimat
approved these changes
Feb 9, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Co-authored-by: gavingaozhangmin <gavingaozhangmin@didiglobal.com>
tisonkun
reviewed
Aug 31, 2022
Comment on lines
+90
to
+91
| boolean zkServerReady = zks.waitForServerUp(zks.getConnectionString(), 30_000); | ||
| assertTrue(zkServerReady); |
Member
There was a problem hiding this comment.
These lines don't help because it's already included in zks.start.
I suspect that it's the CI overwhelmed to be blamed that we can hardly setup a proper timeout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14107
Motivation
Fixes #14107
Modifications
Wait until ZK server started.
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)