[Transaction] Move MetaStoreHandlerNotReadyException and add MetaStoreHandlerHasClosedException#14211
Closed
liangyepianzhou wants to merge 1 commit intoapache:masterfrom
liangyepianzhou:MetaStoreHandlerNotReadyException
Closed
[Transaction] Move MetaStoreHandlerNotReadyException and add MetaStoreHandlerHasClosedException#14211liangyepianzhou wants to merge 1 commit intoapache:masterfrom liangyepianzhou:MetaStoreHandlerNotReadyException
liangyepianzhou wants to merge 1 commit intoapache:masterfrom
liangyepianzhou:MetaStoreHandlerNotReadyException
Conversation
…eHandlerHasClosedException ### Motivation & Modification Makes exceptions on the Transaction client side clearer.
gaoran10
requested review from
codelipenghui,
congbobo184,
eolivelli,
hangc0276 and
zymap
Contributor
|
Sorry, I'm not sure why we need to make the exception |
Contributor
Author
Just my personal opinion
|
Contributor
Author
|
/pulsarbot run-failure-checks |
| @@ -156,8 +157,7 @@ public void testPulsarClientCloseThenCloseTcClient() throws Exception { | |||
| try { | |||
| handler.newTransactionAsync(10, TimeUnit.SECONDS).get(); | |||
Member
There was a problem hiding this comment.
Maybe we need to add fail() here.
|
The pr had no activity for 30 days, mark with Stale label. |
|
The pr had no activity for 30 days, mark with Stale label. |
Member
|
Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master #13918
Motivation & Modification
Makes exceptions on the Transaction client side clearer.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)