[Transaction] Call getCause() after exception wrapped by completeFuture#14214
Merged
codelipenghui merged 4 commits intoapache:masterfrom Feb 28, 2022
liangyepianzhou:fix_getcause
Merged
[Transaction] Call getCause() after exception wrapped by completeFuture#14214codelipenghui merged 4 commits intoapache:masterfrom liangyepianzhou:fix_getcause
codelipenghui merged 4 commits intoapache:masterfrom
liangyepianzhou:fix_getcause
Conversation
### Motivation & Modification Call getCause() after exception wrapped by completeFuture
Jason918
reviewed
Feb 10, 2022
...rc/main/java/org/apache/pulsar/client/impl/transaction/TransactionCoordinatorClientImpl.java
Outdated
Show resolved
Hide resolved
Jason918
reviewed
Feb 10, 2022
...ain/java/org/apache/pulsar/client/api/transaction/TransactionCoordinatorClientException.java
Outdated
Show resolved
Hide resolved
congbobo184
requested review from
codelipenghui,
congbobo184,
eolivelli,
gaoran10 and
merlimat
Jason918
previously approved these changes
Feb 11, 2022
Contributor
codelipenghui
left a comment
codelipenghui
left a comment
There was a problem hiding this comment.
The change looks good to me, could you please add tests for the new changes?
...ain/java/org/apache/pulsar/client/api/transaction/TransactionCoordinatorClientException.java
Outdated
Show resolved
Hide resolved
codelipenghui
approved these changes
Feb 24, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue #13918
Motivation & Modification
Call getCause() after exception wrapped by completeFuture
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)