[feat][broker]: support dynamic update topic broker-level publish-rate#14387
Merged
codelipenghui merged 3 commits intoapache:masterfrom Mar 18, 2022
Merged
[feat][broker]: support dynamic update topic broker-level publish-rate#14387codelipenghui merged 3 commits intoapache:masterfrom
codelipenghui merged 3 commits intoapache:masterfrom
Conversation
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
Show resolved
Hide resolved
Contributor
Author
|
/pulsarbot run-failure-checks |
Jason918
reviewed
Feb 21, 2022
Contributor
Jason918
left a comment
Jason918
left a comment
There was a problem hiding this comment.
Overall LGTM.
Please add unit test for broker level dynamic updating, we missed cover this case.
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
Show resolved
Hide resolved
Contributor
|
+1 please add test for the new changes. |
AnonHxy
force-pushed
the
opt_publishRate_brokerLevel
branch
from
ec3ea32 to
1d49557
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
...roker/src/test/java/org/apache/pulsar/broker/service/PrecisTopicPublishRateThrottleTest.java
Show resolved
Hide resolved
| MessageId messageId = null; | ||
| try { | ||
| // first will be success, and will set auto read to false | ||
| messageId = producer.sendAsync(new byte[expectedRate]).get(500, TimeUnit.MILLISECONDS); |
Contributor
There was a problem hiding this comment.
I think we only need to check the dynamic update is been applied, do not need to check if the rate limier is works or not? because the rate limiter is tested by other tests.
So that we don't introduce Thread.sleep() in this test, which might introduce new flaky tests.
Contributor
There was a problem hiding this comment.
I think we only need to check the dynamic update is been applied, do not need to check if the rate limier is works or not?
+1
Contributor
Author
There was a problem hiding this comment.
Have updated the UT, PTAL @codelipenghui @Jason918
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Mar 18, 2022
codelipenghui
changed the title
codelipenghui
added
type/feature
Jason918
approved these changes
Mar 18, 2022
aparajita89
pushed a commit
to aparajita89/pulsar
that referenced
this pull request
Mar 21, 2022
apache#14387) ### Motivation Dynamic update topic broker-level publish-rate. ### Modifications Invoke `org.apache.pulsar.broker.service.BrokerService#registerConfigurationListener` to register listeners about `maxPublishRatePerTopicInMessages` and `maxPublishRatePerTopicInBytes`
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
apache#14387) ### Motivation Dynamic update topic broker-level publish-rate. ### Modifications Invoke `org.apache.pulsar.broker.service.BrokerService#registerConfigurationListener` to register listeners about `maxPublishRatePerTopicInMessages` and `maxPublishRatePerTopicInBytes`
AnonHxy
added a commit
to AnonHxy/pulsar
that referenced
this pull request
Jul 25, 2022
apache#14387) Dynamic update topic broker-level publish-rate. Invoke `org.apache.pulsar.broker.service.BrokerService#registerConfigurationListener` to register listeners about `maxPublishRatePerTopicInMessages` and `maxPublishRatePerTopicInBytes`
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Dynamic update topic broker-level publish-rate.
Modifications
Invoke
org.apache.pulsar.broker.service.BrokerService#registerConfigurationListenerto register listenersabout
maxPublishRatePerTopicInMessagesandmaxPublishRatePerTopicInBytesVerifying this change
org.apache.pulsar.broker.service.PrecisTopicPublishRateThrottleTest#testMultiLevelPublishRateto test the caseDoes this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
no-need-doc