optimize updateServiceUrl method#14441
Closed
lordcheng10 wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Contributor
Author
|
@hangc0276 PTAL,thanks! |
Contributor
Author
|
/pulsarbot run-failure-checks |
Technoboy-
reviewed
Feb 24, 2022
| @Override | ||
| public synchronized void updateServiceUrl(String serviceUrl) throws PulsarClientException { | ||
| if (serviceUrl != null && serviceUrl.equals(conf.getServiceUrl())) { | ||
| log.info("Ignore service URL to {}，because it is the same as the current service URL!", serviceUrl); |
Contributor
There was a problem hiding this comment.
Ignore service URL -> 'Ignore update service URL' ?
Contributor
Author
There was a problem hiding this comment.
Aha, I made a mistake, here is the judgment of whether the url is equal. I will close this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
optimize updateServiceUrl method
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)