Fix switchBackDelayNs failure problem in class of AutoClusterFailover#14442
Merged
codelipenghui merged 7 commits intoapache:masterfrom Feb 25, 2022
Merged
Conversation
hangc0276
reviewed
Feb 24, 2022
Contributor
hangc0276
left a comment
There was a problem hiding this comment.
@lordcheng10 Nice catch, thanks for your contribution. Would you please help add a test to protect the switch back delay logic?
Contributor
Author
OK ,I will add unit test |
Contributor
Author
Done |
Contributor
Author
|
@hangc0276 @codelipenghui PTAL,thanks! |
hangc0276
approved these changes
Feb 25, 2022
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
@codelipenghui PTAL,thanks! |
codelipenghui
approved these changes
Feb 25, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Consider such a bad case:
pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/AutoClusterFailover.java
Lines 104 to 106 in ced5786
pulsar/pulsar-client/src/main/java/org/apache/pulsar/client/impl/AutoClusterFailover.java
Lines 248 to 250 in ced5786
So we need to judge currentPulsarServiceUrl.equals(primary) again before executing probeAndCheckSwitchBack();
Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)