make setMessageRoutingMode method more readable and optimize unit test for messageRoutingMode#14726
make setMessageRoutingMode method more readable and optimize unit test for messageRoutingMode#14726yws-tracy wants to merge 4 commits intoapache:masterfrom
setMessageRoutingMode method more readable and optimize unit test for messageRoutingMode#14726Conversation
|
@yws-tracy:Thanks for your contribution. For this PR, do we need to update docs? |
|
@yws-tracy:Thanks for providing doc info! |
github-actions
bot
added
doc-not-needed
Jason918
left a comment
Jason918
left a comment
There was a problem hiding this comment.
It‘s better to provide a unit test to make sure the logic stays the same.
there is enough tests about messageRoutingMode, and I supplement the related unit test to ensure the logic is same |
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerBuilderImpl.java
Outdated
Show resolved
Hide resolved
|
why cicd build failed? weird..... build ok in local env, can't it retry to run cicd? |
yws-tracy
changed the title
setMessageRoutingMode method more readablesetMessageRoutingMode method more readable and supplement unit test for messageRoutingMode
You need rebase on latest master. |
yws-tracy
force-pushed
the
optimize_setMessageRoutingMode
branch
from
beecc96 to
555dcc1
Compare
yws-tracy
changed the title
setMessageRoutingMode method more readable and supplement unit test for messageRoutingModesetMessageRoutingMode method more readable and optimize unit test for messageRoutingMode
could you help to review again ? thanks a lot |
|
The pr had no activity for 30 days, mark with Stale label. |
|
The pr had no activity for 30 days, mark with Stale label. |
|
Closed as stale and conflict. Please rebase and resubmit the patch if it's still relevant. |
5 participants
Motivation
when I first read
setMessageRoutingMode, I was confused, the logic is not very clear, and the error hints is not completely right, I try to make the logic more readable and clear, and split into different error hintshope to be adopted, thanks
Modifications
split the check logic in
setMessageRoutingModemethod of classProducerBuilderImplDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)