Skip to content

[improve][doc] Update some auth settings in worker service #14843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RobertIndie merged 3 commits into from
May 25, 2022
Merged

[improve][doc] Update some auth settings in worker service #14843

RobertIndie merged 3 commits into from
May 25, 2022

Conversation

@RobertIndie
Copy link
Member

@RobertIndie RobertIndie commented Mar 24, 2022

Master Issue: #7314

Motivation

#7424 has renamed some settings to make those broker-client TLS settings clearer. But some doc hasn't been updated. This PR updates these settings in the worker service. We need to update this doc in and after version 2.7.0.

Modifications

  • Replace clientAuthenticationParameters with brokerClientAuthenticationParameters
  • Replace clientAuthenticationPlugin with brokerClientAuthenticationPlugin

Documentation

  • doc

@RobertIndie
Update some auth settings in worker service.
cfc2899 
Signed-off-by: Zike Yang <zike@apache.org>
@RobertIndie RobertIndie changed the title [improve][function] Update some auth settings in worker service [improve][doc] Update some auth settings in worker service Mar 24, 2022
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Mar 24, 2022
Anonymitaet
Anonymitaet reviewed Mar 25, 2022
View reviewed changes
@Anonymitaet Anonymitaet added this to the 2.10.0 milestone Mar 25, 2022
@RobertIndie
Apply comments.
7aa0f9b 
Signed-off-by: Zike Yang <zike@apache.org>
@RobertIndie
Copy link
Member Author

RobertIndie commented Mar 25, 2022

@Anonymitaet Thanks! I have updated the PR. PTAL.

@RobertIndie RobertIndie requested a review from Anonymitaet March 25, 2022 04:06
@github-actions
Copy link

github-actions bot commented Apr 25, 2022

The pr had no activity for 30 days, mark with Stale label.

@RobertIndie RobertIndie modified the milestones: 2.10.0, 2.11.0 Apr 25, 2022
@codelipenghui
Copy link
Contributor

codelipenghui commented May 9, 2022

@RobertIndie I think you need to rebase to the master branch

@RobertIndie RobertIndie merged commit edd712c into apache:master May 25, 2022
@tisonkun tisonkun mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codelipenghui codelipenghui codelipenghui approved these changes

@Anonymitaet Anonymitaet Anonymitaet approved these changes

Assignees

@RobertIndie RobertIndie

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@RobertIndie @codelipenghui @Anonymitaet