Skip to content

Improve WebSocket producerBuilderTest#14845

Merged
dlg99 merged 1 commit intoapache:masterfrom
cbornet:ws-params-test
Apr 5, 2022
Merged

Improve WebSocket producerBuilderTest#14845
dlg99 merged 1 commit intoapache:masterfrom
cbornet:ws-params-test

Conversation

@cbornet
Copy link
Contributor

@cbornet cbornet commented Mar 24, 2022

Motivation

Better test coverage

Modifications

Trivial changes

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Run AbstractWebSocketHandlerTest::producerBuilderTest

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API: (yes / no) no
  • The schema: (yes / no / don't know) no
  • The default values of configurations: (yes / no) no
  • The wire protocol: (yes / no) no
  • The rest endpoints: (yes / no) no
  • The admin cli options: (yes / no) no
  • Anything that affects deployment: (yes / no / don't know) no

Documentation

Check the box below or label this PR directly (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Mar 24, 2022
@cbornet
Copy link
Contributor Author

cbornet commented Apr 3, 2022

/pulsarbot rerun-failure-checks

@dlg99 dlg99 added the area/test label Apr 5, 2022
@dlg99 dlg99 merged commit 2944d4c into apache:master Apr 5, 2022
@cbornet cbornet deleted the ws-params-test branch April 5, 2022 17:27
aparajita89 pushed a commit to aparajita89/pulsar that referenced this pull request Apr 6, 2022
Lannnnh pushed a commit to Lannnnh/pulsar that referenced this pull request Apr 6, 2022
Nicklee007 pushed a commit to Nicklee007/pulsar that referenced this pull request Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants