Improve WebSocket producerBuilderTest#14845
Merged
dlg99 merged 1 commit intoapache:masterfrom Apr 5, 2022
Merged
Conversation
dlg99
approved these changes
Mar 29, 2022
lhotari
approved these changes
Mar 29, 2022
michaeljmarshall
approved these changes
Mar 29, 2022
Contributor
Author
|
/pulsarbot rerun-failure-checks |
aparajita89
pushed a commit
to aparajita89/pulsar
that referenced
this pull request
Apr 6, 2022
Lannnnh
pushed a commit
to Lannnnh/pulsar
that referenced
this pull request
Apr 6, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Better test coverage
Modifications
Trivial changes
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)