[refactor][broker] Move loadbalancer used data classes package position#14945
Merged
RobertIndie merged 2 commits intoapache:masterfrom Apr 24, 2022
Conversation
mattisonchao
approved these changes
Mar 30, 2022
RobertIndie
approved these changes
Mar 30, 2022
RobertIndie
added
area/broker
doc-not-needed
Demogorgon314
force-pushed
the
refactor/move-loadbalancer-data-package-position
branch
from
988fb4a to
89864a6
Compare
Demogorgon314
force-pushed
the
refactor/move-loadbalancer-data-package-position
branch
from
c625c09 to
5a42eb4
Compare
Member
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot rerun-failure-checks |
Member
Author
|
/pulsarbot rerun-failure-checks |
1 similar comment
Member
Author
|
/pulsarbot rerun-failure-checks |
Demogorgon314
force-pushed
the
refactor/move-loadbalancer-data-package-position
branch
from
5a42eb4 to
057549d
Compare
Member
Author
|
/pulsarbot rerun-failure-checks |
Demogorgon314
force-pushed
the
refactor/move-loadbalancer-data-package-position
branch
from
057549d to
9bff4b6
Compare
Member
Author
|
/pulsarbot rerun-failure-checks |
Demogorgon314
force-pushed
the
refactor/move-loadbalancer-data-package-position
branch
from
9bff4b6 to
2495632
Compare
Member
Author
|
/pulsarbot rerun-failure-checks |
Member
Author
|
@codelipenghui @RobertIndie The CI is passed. Please take a look if you have time, thanks : ) |
Demogorgon314
deleted the
refactor/move-loadbalancer-data-package-position
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I'm working on improving the loadbalancer, but I find they are four classes used in loadbalancer and the package position is under the
org.apache.pulsar.broker. This is strange because another class namedLocalBrokerDatais inorg.apache.pulsar.policies.data.loadbalancer.We should move it to pulsar-common and put them together with
LocalBrokerDatafor future extensions.Modifications
Move loadbalancer used data classes package position to
org.apache.pulsar.policies.data.loadbalancerDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)