[improve][transaction] Add logs for REST API in transaction

[gaozhangmin]

Motivation

Add logs when broker occur error.

Documentation

Check the box below or label this PR directly.

Need to update docs?

• no-need-doc

code optimize. no new feature added.

[mattisonchao]

Looks like you just add the error log here, a little bit confused about your PR title and description.

[gaozhangmin]

Looks like you just add the error log here, a little bit confused about your PR title and description.

Without this, broker server side logged nothing as issue #14851.

[RobertIndie]

This PR doesn't seem to fix the #14851 . I think we need to find the root cause of this issue.

[Technoboy-]

LGTM

[Technoboy-]

This PR doesn't seem to fix the #14851 . I think we need to find the root cause of this issue.

Only add logs when error. It's not related to #14851.

[RobertIndie]

This PR doesn't seem to fix the #14851 . I think we need to find the root cause of this issue.

Only add logs when error. It's not related to #14851.

Get it. Thanks for your explanation. @Technoboy-

[gaozhangmin]

/pulsarbot run-failure-checks

[mattisonchao]

Looks like we will return 307, and this redirect exception may don't need to log error.

@ApiResponse(code = 307, message = "Topic is not owned by this broker!"),

[gaozhangmin]

Looks like we will return 307, and this redirect exception may don't need to log error.

@ApiResponse(code = 307, message = "Topic is not owned by this broker!"),

@mattisonchao redirection exception is thrown in method validateTopicName. This error won't be caught by CompletableFuture exceptionally

[mattisonchao]

@gaozhangmin
Would you mind checking this code, looks like this method will invoke validateTopicOwnershipAsync?

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/TransactionsBase.java

Lines 145 to 149 in 8757c3a

	protected CompletableFuture<TransactionPendingAckStats> internalGetPendingAckStats(
	boolean authoritative, String subName) {
	return getExistingPersistentTopicAsync(authoritative)
	.thenApply(topic -> topic.getTransactionPendingAckStats(subName));
	}

[gaozhangmin]

@mattisonchao PTAL again.

[gaozhangmin]

/pulsarbot run-failure-checks

[gaozhangmin]

/pulsarbot run-failure-checks