[improve][broker] GetMessageById add RedeliveryCount for output#15095
Merged
tisonkun merged 2 commits intoapache:masterfrom Dec 10, 2022
Merged
[improve][broker] GetMessageById add RedeliveryCount for output#15095tisonkun merged 2 commits intoapache:masterfrom
tisonkun merged 2 commits intoapache:masterfrom
Conversation
|
@leizhiyuan:Thanks for your contribution. For this PR, do we need to update docs? |
|
@leizhiyuan:Thanks for providing doc info! |
github-actions
bot
added
doc-not-needed
AnonHxy
approved these changes
Apr 9, 2022
codelipenghui
approved these changes
Apr 10, 2022
Technoboy-
approved these changes
Apr 11, 2022
|
The pr had no activity for 30 days, mark with Stale label. |
|
The pr had no activity for 30 days, mark with Stale label. |
Contributor
|
/pulsarbot run-failure-checks |
|
The pr had no activity for 30 days, mark with Stale label. |
Contributor
|
/pulsarbot run-failure-checks |
|
The pr had no activity for 30 days, mark with Stale label. |
tisonkun
changed the title
|
@leizhiyuan Please add the following content to your PR description and select a checkbox: |
Codecov Report
@@ Coverage Diff @@
## master #15095 +/- ##
============================================
- Coverage 47.92% 44.68% -3.25%
- Complexity 10679 10694 +15
============================================
Files 703 763 +60
Lines 68831 73596 +4765
Branches 7378 7912 +534
============================================
- Hits 32988 32884 -104
- Misses 32119 37013 +4894
+ Partials 3724 3699 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
github-actions
bot
added
doc-not-needed
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 26, 2022
…he#15095) Co-authored-by: tison <wander4096@gmail.com>
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Dec 29, 2022
…he#15095) Co-authored-by: tison <wander4096@gmail.com>
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
…he#15095) Co-authored-by: tison <wander4096@gmail.com>
asafm
reviewed
Oct 24, 2023
| } | ||
|
|
||
| private void incrementUnackedMessages(int ackedMessages) { | ||
| private void incrementUnackedMessages(int unackedMessages) { |
Contributor
There was a problem hiding this comment.
Yeah, but we also call this with ackedMessages as a negative counter. Yep - very confusing. Very
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #15086
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #15086
Motivation
GetMessageById add RedeliveryCount for output
fix typo
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)