Skip to content

[feature][doc] add examples for creates a Python Client use a listener_name#15386

Merged
Anonymitaet merged 3 commits intoapache:masterfrom
liudezhi2098:doc_support_listener_name_in_python_client
May 5, 2022
Merged

[feature][doc] add examples for creates a Python Client use a listener_name#15386
Anonymitaet merged 3 commits intoapache:masterfrom
liudezhi2098:doc_support_listener_name_in_python_client

Conversation

@liudezhi2098
Copy link
Contributor

@liudezhi2098 liudezhi2098 commented Apr 29, 2022

Master Issue: #15353
Preview looks good:
image

Need to update docs?

  • doc

@github-actions
Copy link

@liudezhi2098:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@momo-jun
Copy link
Contributor

In addition, I propose more changes to the PR:

  • Add [feature] to the PR title to conform to the latest naming convention.
  • Add "- [x] doc " in the PR description to attach the doc label.

liudezhi2098 and others added 2 commits April 29, 2022 17:49
Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com>
Co-authored-by: momo-jun <60642177+momo-jun@users.noreply.github.com>
@liudezhi2098 liudezhi2098 changed the title [DOC] add examples for creates a Python Client use a listener_name [feature] add examples for creates a Python Client use a listener_name Apr 29, 2022
@liudezhi2098 liudezhi2098 changed the title [feature] add examples for creates a Python Client use a listener_name [feature][doc] add examples for creates a Python Client use a listener_name Apr 29, 2022
Copy link
Contributor

@momo-jun momo-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
//cc @Anonymitaet

@Anonymitaet Anonymitaet added doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels May 5, 2022
@Anonymitaet Anonymitaet merged commit c2b5074 into apache:master May 5, 2022
@lhotari lhotari mentioned this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants