[broker]Fix subscribeRateLimiter not close#15457
Merged
codelipenghui merged 3 commits intoapache:masterfrom May 7, 2022
Merged
[broker]Fix subscribeRateLimiter not close#15457codelipenghui merged 3 commits intoapache:masterfrom
codelipenghui merged 3 commits intoapache:masterfrom
Conversation
AnonHxy
force-pushed
the
fix_subscribeRateLimiter_close
branch
from
3d63e84 to
7d08241
Compare
AnonHxy
force-pushed
the
fix_subscribeRateLimiter_close
branch
from
7d08241 to
416a733
Compare
gaozhangmin
requested review from
eolivelli and
michaeljmarshall
and removed request for
michaeljmarshall
gaozhangmin
requested review from
Jason918,
eolivelli and
michaeljmarshall
and removed request for
eolivelli
gaozhangmin
approved these changes
May 6, 2022
Member
michaeljmarshall
left a comment
michaeljmarshall
left a comment
There was a problem hiding this comment.
@AnonHxy thanks for your contributions. I left a few comments.
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
Contributor
|
Method |
Contributor
Author
|
PTAL again, thx @poorbarcode @michaeljmarshall |
Contributor
Author
|
/pulsarbot run-failure-checks |
Jason918
requested changes
May 7, 2022
...r-broker/src/main/java/org/apache/pulsar/broker/service/persistent/SubscribeRateLimiter.java
Show resolved
Hide resolved
Jason918
approved these changes
May 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Close
subscribeRateLimiterif it changes from non-empty to empty, when namespace level or topic level or broker level policies updatedModifications
All modifications are located at
org.apache.pulsar.broker.service.persistent.PersistentTopicVerifying this change
Documentation
no-need-doc