[doc] fix the FORWARD_TRANSITIVE compatibility check logic.#15470
Closed
yangl wants to merge 1 commit intoapache:masterfrom
Closed
[doc] fix the FORWARD_TRANSITIVE compatibility check logic.#15470yangl wants to merge 1 commit intoapache:masterfrom
FORWARD_TRANSITIVE compatibility check logic.#15470yangl wants to merge 1 commit intoapache:masterfrom
Conversation
Member
|
@congbobo184 can you review this PR from the technical perspective? |
codelipenghui
requested changes
May 8, 2022
Contributor
codelipenghui
left a comment
There was a problem hiding this comment.
The check logic is for a new schema, for FORWARD_TRANSITIVE compatibility, the new schema should be able to read the data from the last schema and should be able to be read by all the existing schema.
@congbobo184 Please help confirm
Contributor
|
if schema is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
FORWARD_TRANSITIVE | Can read the last schema-->Can read all schemasCompatibility check strategy
Check logic
ALWAYS_COMPATIBLEAll pass
ALWAYS_INCOMPATIBLENo pass
BACKWARDCan read the last schema
BACKWARD_TRANSITIVECan read all schemas
FORWARDCan read the last schema
FORWARD_TRANSITIVECan read the last schema --> Can read all schemas
FULLCan read the last schema
FULL_TRANSITIVECan read all schemas
Modifications
update the FORWARD_TRANSITIVE check logic to
Can read all schemasVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
no-need-doc(Please explain why)
doc(Your PR contains doc changes)
doc-added(Docs have been already added)