Skip to content

[doc] fix the FORWARD_TRANSITIVE compatibility check logic.#15470

Closed
yangl wants to merge 1 commit intoapache:masterfrom
yangl:schema_check
Closed

[doc] fix the FORWARD_TRANSITIVE compatibility check logic.#15470
yangl wants to merge 1 commit intoapache:masterfrom
yangl:schema_check

Conversation

@yangl
Copy link
Contributor

@yangl yangl commented May 6, 2022

Motivation

FORWARD_TRANSITIVE | Can read the last schema --> Can read all schemas

Compatibility check strategy

Check logic

ALWAYS_COMPATIBLE

All pass

ALWAYS_INCOMPATIBLE

No pass

BACKWARD

Can read the last schema

BACKWARD_TRANSITIVE

Can read all schemas

FORWARD

Can read the last schema

FORWARD_TRANSITIVE

Can read the last schema --> Can read all schemas

FULL

Can read the last schema

FULL_TRANSITIVE

Can read all schemas

Modifications

update the FORWARD_TRANSITIVE check logic to Can read all schemas

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • no-need-doc
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-added
    (Docs have been already added)

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label May 6, 2022
@Anonymitaet
Copy link
Member

@congbobo184 can you review this PR from the technical perspective?

@Anonymitaet Anonymitaet requested a review from codelipenghui May 6, 2022 11:10
Copy link
Contributor

@codelipenghui codelipenghui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The check logic is for a new schema, for FORWARD_TRANSITIVE compatibility, the new schema should be able to read the data from the last schema and should be able to be read by all the existing schema.

@congbobo184 Please help confirm

@congbobo184
Copy link
Contributor

if schema is FORWARD_TRANSITIVE, consumer only can read the last schema, because in FORWARD_TRANSITIVE, we need to upgrade producer first, so in FORWARD_TRANSITIVE, we only check can read the last schem is enough.
@yangl

@yangl yangl closed this May 12, 2022
@yangl yangl deleted the schema_check branch May 12, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants