[improve][doc] Include Elasticsearch sink compatibility #15515
Merged
Technoboy- merged 4 commits intoapache:masterfrom May 14, 2022
Merged
[improve][doc] Include Elasticsearch sink compatibility #15515Technoboy- merged 4 commits intoapache:masterfrom
Technoboy- merged 4 commits intoapache:masterfrom
Conversation
github-actions
bot
added
the
doc
nicoloboschi
requested changes
May 9, 2022
nicoloboschi
approved these changes
May 9, 2022
1 task
Anonymitaet
reviewed
May 10, 2022
Member
Anonymitaet
left a comment
Anonymitaet
left a comment
There was a problem hiding this comment.
can you please rename your PR? eg. [improve][doc] xxx
guideline: https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35
site2/docs/io-elasticsearch-sink.md
Outdated
|
|
||
| ## Requirements | ||
|
|
||
| To deploy an ElasticSearch sink connector, the following are required: |
Member
There was a problem hiding this comment.
Suggested change
| To deploy an ElasticSearch sink connector, the following are required: | |
| To deploy an Elasticsearch sink connector, meet the following requirements. |
Contributor
There was a problem hiding this comment.
The original seems better.
Member
There was a problem hiding this comment.
- Elasticsearch, lower case for "s" is correct
- The subject of "To deploy an Elasticsearch sink connector" is "you" (user), so the subject of the latter sentence should be "you" as well. The subject of "meet the following requirements." is you.
Contributor
There was a problem hiding this comment.
- Elasticsearch, lower case for "s" is correct
Sure
- The subject of "To deploy an Elasticsearch sink connector" is "you" (user), so the subject of the latter sentence should be "you" as well. The subject of "meet the following requirements." is you.
I'm a little not agree. I prefer the original.
mendonk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15514