[fix][broker] ensure new line added before appending new keys from env#15596
Merged
Technoboy- merged 1 commit intoapache:masterfrom May 14, 2022
marksilcox:fix_apply_config_prefix
Merged
[fix][broker] ensure new line added before appending new keys from env#15596Technoboy- merged 1 commit intoapache:masterfrom marksilcox:fix_apply_config_prefix
Technoboy- merged 1 commit intoapache:masterfrom
marksilcox:fix_apply_config_prefix
Conversation
2 tasks
merlimat
approved these changes
May 13, 2022
eolivelli
approved these changes
May 13, 2022
Technoboy-
approved these changes
May 14, 2022
codelipenghui
approved these changes
May 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Copying change from
apply-config-from-env.pyto ensure new line included before appendingVerifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Need to update docs?
no-need-doc(Please explain why)