Skip to content

[fix][doc] Clarifying non-persistent topics a bit more#15720

Merged
Anonymitaet merged 3 commits intoapache:masterfrom
asafm:non-persistent-topic-docs
May 26, 2022
Merged

[fix][doc] Clarifying non-persistent topics a bit more#15720
Anonymitaet merged 3 commits intoapache:masterfrom
asafm:non-persistent-topic-docs

Conversation

@asafm
Copy link
Copy Markdown
Contributor

@asafm asafm commented May 23, 2022

Modifications

  • Clarify the notion that non-persistent topics do not buffer in-memory messages at all.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • no-need-doc
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-added
    (Docs have been already added)

@github-actions
Copy link
Copy Markdown

@asafm:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions
Copy link
Copy Markdown

@asafm:Thanks for providing doc info!

@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label May 23, 2022
Copy link
Copy Markdown
Member

@Anonymitaet Anonymitaet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Does this apply to other doc versions? If so, would you like to update them?

@Technoboy- Technoboy- added this to the 2.11.0 milestone May 24, 2022
@asafm
Copy link
Copy Markdown
Contributor Author

asafm commented May 25, 2022

Thanks for your contribution!

Does this apply to other doc versions? If so, would you like to update them?

@Anonymitaet It does but if I need to update all previous versions everytime I make a typo it will despair me :)

@Anonymitaet
Copy link
Copy Markdown
Member

despair

@asafm just batch and replace in one click


By default, non-persistent topics are enabled on Pulsar brokers. You can disable them in the broker's [configuration](reference-configuration.md#broker-enableNonPersistentTopics). You can manage non-persistent topics using the `pulsar-admin topics` command. For more information, see [`pulsar-admin`](https://pulsar.apache.org/tools/pulsar-admin/).

Currently non-persistent topics which are not partitioned are not persisted to ZK, which means if the broker owning them crashes, they won't get re-assigned to another broker because they only existed in the owner broker memory. The current work-around for that is to make sure `allowAutoTopicCreation` broker config is `true` and `allowAutoTopicCreationType` is `non-partitioned` (Those the the default values).
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Currently non-persistent topics which are not partitioned are not persisted to ZK, which means if the broker owning them crashes, they won't get re-assigned to another broker because they only existed in the owner broker memory. The current work-around for that is to make sure `allowAutoTopicCreation` broker config is `true` and `allowAutoTopicCreationType` is `non-partitioned` (Those the the default values).
Currently, non-persistent topics which are not partitioned are not persisted to ZooKeeper, which means if the broker owning them crashes, they do not get re-assigned to another broker because they only exist in the owner broker memory. The current workaround is to set the value of `allowAutoTopicCreation` to `true` and `allowAutoTopicCreationType` to `non-partitioned` (they are default values) in broker configuration.

Copy link
Copy Markdown
Member

@Anonymitaet Anonymitaet May 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anonymitaet fixed

@Anonymitaet Anonymitaet merged commit f23eb1f into apache:master May 26, 2022
@asafm asafm deleted the non-persistent-topic-docs branch May 29, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants