Fix schema stats prometheus summary memory leak #15801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fu-turer
approved these changes
May 26, 2022
coderzc
approved these changes
May 26, 2022
hezhangjian
force-pushed
the
prometheus-summary-memory-leak
branch
from
69b0fa5 to
8bd6875
Compare
hezhangjian
force-pushed
the
prometheus-summary-memory-leak
branch
from
8bd6875 to
07eae62
Compare
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
@merlimat @codelipenghui PTAL |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#14723 introduces
schemaIdlabel metrics.Prometheus summary maintains a map to record label and value,
summarywill not auto-release the label. Which will leads to memory leak.We missed to unRecord label when schemaId were deleted.
Modifications
unRecord schema when schemaId deleted