[broker][monitoring] Support gzip compression when expose metrics data#16197
Closed
tjiuming wants to merge 1 commit intoapache:masterfrom
Closed
[broker][monitoring] Support gzip compression when expose metrics data#16197tjiuming wants to merge 1 commit intoapache:masterfrom
tjiuming wants to merge 1 commit intoapache:masterfrom
Conversation
merlimat
reviewed
Jun 23, 2022
| boolean enableCompress) throws IOException { | ||
| try { | ||
| if (enableCompress) { | ||
| out = new GZIPOutputStream(out); |
Contributor
There was a problem hiding this comment.
I think GZIPOutputStream will create a lot of garbage on the JVM heap :|
Could we just use org.apache.pulsar.common.compression.CompressionCodecZLib on the buffer?
Contributor
Author
There was a problem hiding this comment.
@merlimat But CompressionCodecZLib not in GZIP format, and Prometheus read metrics data in GZIP format:
if s.gzipr == nil {
s.buf = bufio.NewReader(resp.Body)
s.gzipr, err = gzip.NewReader(s.buf)
if err != nil {
return "", err
}
} else {
s.buf.Reset(resp.Body)
if err = s.gzipr.Reset(s.buf); err != nil {
return "", err
}
}
n, err := io.Copy(w, io.LimitReader(s.gzipr, s.bodySizeLimit))
s.gzipr.Close()
if err != nil {
return "", err
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
support gzip compression when expose metrics data
Modifications
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)