Skip to content

[improve][function] When restart function, if assigned work does not exist, print warn log. #16303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Technoboy- merged 1 commit into from
Jul 31, 2022
Merged

[improve][function] When restart function, if assigned work does not exist, print warn log. #16303

Technoboy- merged 1 commit into from
Jul 31, 2022

Conversation

@shibd
Copy link
Member

@shibd shibd commented Jun 30, 2022 •
edited
Loading

Motivation

In the implementation of the function framework, assignments are updated asynchronously to each worker. When restarting the function, there may be some work in an assignment that does not exist. This scenario should be printed warn log to the broker.

Modifications

  • When restart function, if assigned work does not exist, print warn log.

Documentation

  • doc-not-needed

@shibd shibd marked this pull request as ready for review June 30, 2022 10:13
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 30, 2022
@shibd
Copy link
Member Author

shibd commented Jun 30, 2022

/pulsarbot run-failure-checks

1 similar comment
@shibd
Copy link
Member Author

shibd commented Jun 30, 2022

/pulsarbot run-failure-checks

@shibd shibd force-pushed the fix_function_log branch from c232ea7 to afb9820 Compare July 1, 2022 07:04
nahguam
nahguam approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@nahguam nahguam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shibd shibd force-pushed the fix_function_log branch from afb9820 to 7ee7cbf Compare July 5, 2022 02:36
@shibd
Copy link
Member Author

shibd commented Jul 5, 2022

/pulsarbot run-failure-checks

1 similar comment
@shibd
Copy link
Member Author

shibd commented Jul 5, 2022

/pulsarbot run-failure-checks

@Technoboy- Technoboy- added this to the 2.11.0 milestone Jul 31, 2022
@Technoboy- Technoboy- merged commit bdbe397 into apache:master Jul 31, 2022
Gleiphir2769 pushed a commit to Gleiphir2769/pulsar that referenced this pull request Aug 4, 2022
@shibd @Gleiphir2769
When restart function, if assigned work does not exist, print warn lo…
cc39c47 
…g. (apache#16303)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@nlu90 nlu90 nlu90 approved these changes

+1 more reviewer

@nahguam nahguam nahguam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@shibd shibd

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

4 participants

@shibd @nahguam @Technoboy- @nlu90