Skip to content

Conversation

@HQebupt
Copy link
Contributor

@HQebupt HQebupt commented Jul 14, 2022

Motivation

Fixed #15946 due to It miss v1/Namespaces.java.

See PIP #14365 and change tracker #15043.
Make removePublishRate / getPublishRate / getDispatchRate / setDispatchRate / deleteDispatchRate methods in NamespacesBase to pure async.

Verifying this change

Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-not-needed

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 14, 2022
@HQebupt
Copy link
Contributor Author

HQebupt commented Jul 15, 2022

/pulsarbot run-failure-checks

@Technoboy-
Copy link
Contributor

V1 is no longer recommended to fix

@HQebupt
Copy link
Contributor Author

HQebupt commented Jul 15, 2022

V1 is no longer recommended to fix

Good.

@HQebupt HQebupt closed this Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants