[fix][broker]avoid the bestBroker choice broker exceed candidates when selectBroker in LeastResourceUsageWithWeight #16743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
requested changes
Jul 22, 2022
Member
shibd
left a comment
shibd
left a comment
There was a problem hiding this comment.
Nice catch! Could you add a unit test to protect this change?
gaozhangmin
approved these changes
Jul 22, 2022
codelipenghui
added
release/2.10.2
release/2.9.4
type/bug
Contributor
+1 Please add test to avoid regression. |
Contributor
|
Nice catch. +1 |
HQebupt
approved these changes
Jul 23, 2022
Contributor
Author
@codelipenghui @shibd add unit test,PTAL~ |
Demogorgon314
approved these changes
Jul 24, 2022
...er/src/main/java/org/apache/pulsar/broker/loadbalance/impl/LeastResourceUsageWithWeight.java
Outdated
Show resolved
Hide resolved
Nicklee007
force-pushed
the
fix-selectBroker-out-of-candidates-in-LeastResourceUsageWithWeight
branch
from
f730f3f to
fb9762b
Compare
shibd
approved these changes
Jul 25, 2022
Nicklee007
force-pushed
the
fix-selectBroker-out-of-candidates-in-LeastResourceUsageWithWeight
branch
from
fb9762b to
e6d53fa
Compare
Contributor
Author
|
/pulsarbot run-failure-checks |
Gleiphir2769
pushed a commit
to Gleiphir2769/pulsar
that referenced
this pull request
Aug 4, 2022
…n selectBroker in LeastResourceUsageWithWeight (apache#16743) * avoid the bestBroker exceed candidates when selectBroker * add some unit test. * improve the restart broker can load bundle as one of the best brokers Co-authored-by: nicklixinyang <nicklixinyang@didiglobal.com>
Contributor
|
Removed the release/2.10.2 and release/2.9.4 labels since we don't have LeastResourceUsageWithWeight on branch-2.10 and branch-2.9 |
dragonls
pushed a commit
to dragonls/pulsar
that referenced
this pull request
Oct 21, 2022
…n selectBroker in LeastResourceUsageWithWeight (apache#16743) * avoid the bestBroker exceed candidates when selectBroker * add some unit test. * improve the restart broker can load bundle as one of the best brokers Co-authored-by: nicklixinyang <nicklixinyang@didiglobal.com> (cherry picked from commit 0c1b3de)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Avoid the bestBroker choice broker exceed candidates when selectBroker in LeastResourceUsageWithWeight.
When loadManager leader running a period of time,
brokerAvgResourceUsageWithWeightwill contain almost all brokers, the judge will cause we selected broker exceed candidates, it's out of expectation.Modifications
candidatescontain the broker before add the broker tobestBrokers.Documentation
doc-not-needed(Please explain why)