[improve][txn] PIP-160 admin api coordinatorStats append batch info #16748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Jul 23, 2022
Contributor
codelipenghui
left a comment
codelipenghui
left a comment
There was a problem hiding this comment.
LGTM, please check the failed test.
codelipenghui
added
area/transaction
component/stats
type/enhancement
Technoboy-
reviewed
Jul 23, 2022
| /** | ||
| * If enabled the feature-batch, this attribute means maximum wait time(in millis) for the first record in a batch. | ||
| */ | ||
| private int batchedWriteMaxDelayInMillis; |
Contributor
There was a problem hiding this comment.
Please help check the naming of the above fields @momo-jun
Contributor
There was a problem hiding this comment.
I made a few suggestions for the annotation.
Contributor
liangyepianzhou
left a comment
liangyepianzhou
left a comment
There was a problem hiding this comment.
I do not understand why the users need the admin API to get the configuration of the transaction batch. The configuration is what the user configures in broker.conf, isn't it?
momo-jun
reviewed
Jul 25, 2022
| /** Whether to enable the batch feature when writing to Bookie. **/ | ||
| private boolean batchEnabled = false; | ||
|
|
||
| /** If enabled the feature-batch, this attribute means maximum log records count in a batch. **/ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** If enabled the feature-batch, this attribute means maximum log records count in a batch. **/ | |
| /** If the batch feature is enabled, this attribute means the maximum count of log records in a batch. **/ |
momo-jun
reviewed
Jul 25, 2022
| private int batchedWriteMaxSize; | ||
|
|
||
| /** | ||
| * If enabled the feature-batch, this attribute means maximum wait time(in millis) for the first record in a batch. |
Contributor
There was a problem hiding this comment.
Suggested change
| * If enabled the feature-batch, this attribute means maximum wait time(in millis) for the first record in a batch. | |
| * If the batch feature is enabled, this attribute means the maximum wait time (in milliseconds) for the first record in a batch. |
momo-jun
reviewed
Jul 25, 2022
| /** If enabled the feature-batch, this attribute means maximum log records count in a batch. **/ | ||
| private int batchedWriteMaxRecords = 512; | ||
|
|
||
| /** If enabled the feature-batch, this attribute means bytes size in a batch. **/ |
Contributor
There was a problem hiding this comment.
Suggested change
| /** If enabled the feature-batch, this attribute means bytes size in a batch. **/ | |
| /** If the batch feature is enabled, this attribute means the maximum size of bytes in a batch. **/ |
Contributor
Author
OK, I have make this PR to "draft" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master Issue: #15370
Motivation
see #15370
Modifications
I will complete proposal #15370 with these pull requests( current pull request is a part of step-6 ):
TxnLogBufferedWriterGET /admin/v3/transactions/coordinatorStats
GET /admin/v3/transactions/pendingAckStats/:tenant/:namespace:/:topic:/:subName
Documentation
doc-requireddoc-not-neededdocdoc-complete