[Branch 2.7] Fix license check failure #16873
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
Closing this for now. There are other PRs breaks branch 2.7 CI. Reverts them first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After cherry-pick #11790 to branch 2.7, there is a license check issue:
The root cause is that in branch 2.7,
pulsar-presto-distributionis not a child of Pulsar main project. So the version changes in mainpom.xmlis not applied to lib/presto/LICENSE.Modifications
Add dependency of aircompressor-0.20 in
pulsar-sql/presto-distribution/pom.xml.Verifying this change
This change is already covered by existing tests, such as CI license check.
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-not-neededbug fix