[fix][tests] Fix the flaky test MultiTopicsConsumerImplTest.testParallelSubscribeAsync#17146
Closed
Technoboy- wants to merge 1 commit intoapache:masterfrom
Closed
[fix][tests] Fix the flaky test MultiTopicsConsumerImplTest.testParallelSubscribeAsync#17146Technoboy- wants to merge 1 commit intoapache:masterfrom
Technoboy- wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
|
please cherry pick to 2.11 branch |
mattisonchao
approved these changes
Aug 18, 2022
Member
mattisonchao
left a comment
There was a problem hiding this comment.
This change LGTM,
// Test uses a mocked PulsarClientImpl which will complete the getPartitionedTopicMetadata() internal async call
// after a delay longer than the interval between the two subscribeAsync() calls in the test method body.
//
// Code under tests is using CompletableFutures. Theses may hang indefinitely if code is broken.
// That's why a test timeout is defined.
From the comments here, It looks like the code is broken. I think we have to know why the CompletableFuture is not complete yet.
Contributor
Author
|
Fixed by #17049 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It fails several times for elapsing over 5s... Maybe we can change the timeout from 5s to 10s.
https://github.com/apache/pulsar/runs/7875666006?check_suite_focus=true#step:10:3683
https://github.com/apache/pulsar/runs/7875666006?check_suite_focus=true#step:10:3684
https://github.com/apache/pulsar/runs/7875666006?check_suite_focus=true#step:10:3685
https://github.com/apache/pulsar/runs/7875666006?check_suite_focus=true#step:10:3686
https://github.com/apache/pulsar/runs/7875666006?check_suite_focus=true#step:10:3687
Documentation
doc-not-needed