[fix][test] Fix flaky test TopicReaderTest.testMultiReaderIsAbleToSeekWithTimeOnMiddleOfTopic#17147
Closed
nicoloboschi wants to merge 3 commits intoapache:masterfrom
Conversation
54febc8 to
6b5ef38
Compare
…meOnMiddleOfTopic
Member
|
I think it is not the test problem. maybe we can try to fix the seek operation. FYI: #16757 (comment) |
Contributor
Author
|
OK great, didn't notice that pull, will close this pull |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Sometimes this test fails with
This is because while the reader tries to seek to a fixed position, the dispatcher have already sent messages starting from the Earliest position.
Even if the consumer on the client side empties the incoming messages after the cursor reset, the messages may already be on the client side and not enqued yet. I think this is a little defeat of the seek feature
Modifications
doc-not-needed