[fix][test] Fix PersistentDispatcherFailoverConsumerTest#testAddRemoveConsumer wrong logic.
#17216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
From issue #14540, I found this test has some logic problems.
Look at step 7 in the test. If we remove the last consumer, the active consumer will change. The logic you can see at
AbstractDispatcherSingleActiveConsumer#pickAndScheduleActiveConsumermethod.At this time, We will get three notifications. The current new active consumer is
consumer1, So If we removeconsumer0. We will not get a notification.I'm unsure if we can fix the #14540, but the original flaky relative logic is changed.
Modifications
pickAndScheduleActiveConsumer.Verifying this change
Documentation
doc-not-needed(Please explain why)