Skip to content

Conversation

@mattisonchao
Copy link
Member

Motivation

From issue #14540, I found this test has some logic problems.

Look at step 7 in the test. If we remove the last consumer, the active consumer will change. The logic you can see at AbstractDispatcherSingleActiveConsumer#pickAndScheduleActiveConsumer method.

At this time, We will get three notifications. The current new active consumer is consumer1, So If we remove consumer0. We will not get a notification.

I'm unsure if we can fix the #14540, but the original flaky relative logic is changed.

Modifications

  • Fix the wrong test logic to fit the pickAndScheduleActiveConsumer.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-not-needed
    (Please explain why)

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 23, 2022
@mattisonchao mattisonchao self-assigned this Aug 23, 2022
@mattisonchao mattisonchao added this to the 2.12.0 milestone Aug 23, 2022
Copy link
Member

@lhotari lhotari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs type/flaky-tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants